Repository navigation
Type inference: Remove ParenExpr - #23025
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the removal of the unused ParenExpr abstraction.
No open issues 🎉
What changed in this PR
This PR removes the unused ParenExpr abstraction from shared type inference and its Unified and Rust adapters, simplifying the input contract.
Changes:
- Remove
ParenExprfrom the shared signature and its associated type-propagation rule. - Delete the corresponding placeholder classes from the Unified and Rust adapters.
| File | Description |
|---|---|
unified/ql/lib/codeql/unified/internal/typeinference/TypeInference.qll |
Remove the empty ParenExpr implementation. |
shared/typeinference/codeql/typeinference/internal/TypeInference.qll |
Remove the ParenExpr signature and propagation rule. |
rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll |
Remove the placeholder ParenExpr class. |
Review effort: Balanced (auto)
aschackmull
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.